Skip to content

chore(): upgrade NX to v21.2.4 #19604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

chore(): upgrade NX to v21.2.4 #19604

merged 1 commit into from
Oct 29, 2025
+544 −558

Conversation

@toufali
Copy link
Member

@toufali toufali commented Oct 27, 2025

Because

  • Our prev version of NX (21.1.2) included transitive deps that were flagged vulnerabilities by GitHub

This pull request

  • bumps us to the latest patch of the next minor version (21.2.4)

Issue that this pull request solves

Closes: FXA-12577

Other information (Optional)

I tried bumping even further (21.3 and beyond) but these required bumping @nx/jest which subsequently breaks our build due to deprecated methods.

@toufali toufali requested a review from a team as a code owner October 27, 2025 21:07
dschom
dschom reviewed Oct 28, 2025
View reviewed changes
dschom
dschom reviewed Oct 28, 2025
View reviewed changes
dschom
dschom reviewed Oct 28, 2025
View reviewed changes
@toufali toufali force-pushed the upgrade-nx-21.2.4 branch 7 times, most recently from 127eff0 to f576887 Compare October 28, 2025 20:55
@toufali
Copy link
Member Author

toufali commented Oct 28, 2025

Thanks for the review @dschom – addressed your comments and confirmed Storybook working as expected 👍

@dschom
Copy link
Contributor

dschom commented Oct 28, 2025

@toufali Thanks for the updates and the feedback.

@toufali toufali merged commit 16422eb into main Oct 29, 2025
19 checks passed
@toufali toufali deleted the upgrade-nx-21.2.4 branch October 29, 2025 14:46
@toufali toufali mentioned this pull request Oct 29, 2025
Open
@julianpoy
Copy link
Member

Did you use nx migrate for this? Just wanted to comment that we should be using the nx migration tool to make sure associated packages are also bumped, since nx has migrations that are generated between versions

@toufali
Copy link
Member Author

toufali commented Oct 29, 2025

Did you use nx migrate for this? Just wanted to comment that we should be using the nx migration tool to make sure associated packages are also bumped, since nx has migrations that are generated between versions

Yup! nx migrate was used 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dschom dschom dschom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@toufali @dschom @julianpoy